BREAKING: remove solid.js dependency and redo collection interface#114
Closed
williamhorning wants to merge 8 commits intostoatchat:mainfrom
williamhorning:bye-bye-solid
Closed
BREAKING: remove solid.js dependency and redo collection interface#114williamhorning wants to merge 8 commits intostoatchat:mainfrom williamhorning:bye-bye-solid
williamhorning wants to merge 8 commits intostoatchat:mainfrom
williamhorning:bye-bye-solid
Conversation
2 tasks
10 tasks
Contributor
Author
|
looks like i messed up the lockfile on that merge conflict fix attempt, i'll get back to this pr and #111 when i get the chance |
Contributor
Author
|
i can't figure out how to deal with the merge changes here, so i guess this will be part of the other pr |
github-project-automation
bot
moved this from 🆕 Untriaged
to Closed
in Pull Request Overview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this removes all of the
solid.jsdependencies from revolt.js. the majority of the consumers of the library are bots which don't need or use any of these primitives. this does break frontend, though, so don't merge this right away please